add functional tests + use savepoints if possible

dmaicher / doctrine-test-bundle

Symfony bundle to isolate your app's doctrine database tests and improve the test performance

MIT License

1.08k stars 62 forks source link

add functional tests + use savepoints if possible #37

Closed dmaicher closed 7 years ago

dmaicher commented 7 years ago

add functional test that use mysql DB
use savepoints if possible for nested transactions as it makes rolling back transactions easier

Jean85 commented 7 years ago

Damn, since we allowed PHPUnit 6 it makes those tests fail with the legacy listener. IMHO you should run those tests only with PHPUnit 5 under PHP 5.6. Probably @requires is helpful here: https://phpunit.de/manual/current/en/incomplete-and-skipped-tests.html#incomplete-and-skipped-tests.skipping-tests-using-requires

dmaicher commented 7 years ago

@Jean85 actually I found a nicer way so we don't even need two different classes for the listener :blush:

Jean85 commented 7 years ago

Yep I've seen it, it's a nice way to conflate those two classes. By the way, you should either bump to a major version or implement some alias to avoid a BC for those that where using a different (Legacy-) listener class name.

dmaicher commented 7 years ago

Yes indeed makes sense to not break BC in a minor release :+1: I will just release this as 4.0.0.