search

dmaicher / doctrine-test-bundle

Symfony bundle to isolate your app's doctrine database tests and improve the test performance
MIT License
1.08k stars 61 forks source link

Drop support for PHPUnit 6? #81

Closed dmaicher closed 5 years ago

dmaicher commented 5 years ago

We should consider dropping support for PHPUnit 6 with the build-in listener.

Its not supported anymore: https://phpunit.de/supported-versions.html

Also when using PHPUnit 6.4+ but < 7 there are deprecations: https://github.com/dmaicher/doctrine-test-bundle/issues/79

I don't think its worth fixing them for this legacy version of PHPUnit.

If we move forward this should be released as a new major release as it would be a BC break for people using PHPUnit 6.

@garak @mnapoli @B-Galati what do you think?

mnapoli commented 5 years ago

@dmaicher honestly you should do what's simplest for you to maintain. Existing releases will still work anyway for those still on v6.

Also technically I'm not sure this is a BC break since Composer will deal with version constraints and won't install new updates for people on PHPUnit 6. But it's up to you, sometimes doing a BC break is clearer for users.

dmaicher commented 5 years ago

@mnapoli actually it will be a BC break as this bundle does not have a hard dependency on phpunit (so it works with symfony's phpunit bridge and simple-phpunit-script as well for example).

Maybe we could add a "conflicts" for phpunit 6 though.

B-Galati commented 5 years ago

New major that supports only PhpUnit 7+ sounds good to me.

Given the stability of this library, current version can stay unmaintained IMHO once the new major is released .

B-Galati commented 5 years ago

Perhaps there is some work to do at runtime to detect Symfony phpunit bridge version that woul not be compatible.