dmalhotra / pvfmm

A parallel kernel-independent FMM library for particle and volume potentials
http://pvfmm.org
GNU Lesser General Public License v3.0
51 stars 28 forks source link

Add periodic boundary condition support #10

Closed blackwer closed 3 years ago

blackwer commented 4 years ago

I hope this gigantic unsolicited pull request isn't out of line. @wenyan4work authored the majority of these changes to add periodic boundary conditions to pvfmm. I removed most of the bits that overrode build options in the original code.

Rather than permanently maintaining our fork, we were hoping to merge our changes upstream. Our goal is to maintain a conda-forge variant of a periodic capable version of this library and Wen's PeriodicFMM library with python bindings so that people can more easily use them without all the complications that come with build environments in general. We've also developed a mostly functioning cmake build system for pvfmm and would be happy to polish and merge that in as well, if it's something you're interested in.

blackwer commented 3 years ago

Addressed by 9240621