Open Rudd-O opened 1 year ago
❌ Merging this PR will decrease code quality in the affected files by 0.38%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.38 ⭐ | 1.37 ⭐ | -0.01 👍 |
Method Length | 177.62 😞 | 179.08 😞 | 1.46 👎 |
Working memory | 12.84 😞 | 13.03 😞 | 0.19 👎 |
Quality | 63.71% 🙂 | 63.33% 🙂 | -0.38% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 1044 | 1048 | 4 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
components/ble_keyboard/__init__.py | 74.47% 🙂 | 74.34% 🙂 | -0.13% 👎 |
components/ble_keyboard/const.py | 35.25% 😞 | 35.25% 😞 | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
components/ble_keyboard/__init__.py | ble_keyboard_press_to_code | 2 ⭐ | 125 😞 | 8 🙂 | 68.04% 🙂 | Try splitting into smaller methods |
components/ble_keyboard/__init__.py | ble_keyboard_combination_to_code | 0 ⭐ | 132 😞 | 8 🙂 | 69.20% 🙂 | Try splitting into smaller methods |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
hello?
Thanks for the review! Your changes have been committed.
With some devices, it is preferable simply not to advertise at all the return of the ESP keyboard once it restarts.
This option enables users to choose that.
They can create a switch to turn advertisements off in this way: