search

dmamontov / hass-ledfx

LedFx for Home Assistant
https://community.home-assistant.io/t/ledfx-deep-integration-component/366750
Apache License 2.0
44 stars 6 forks source link

#22 Add global play/pause #24

Open guix77 opened 1 year ago

guix77 commented 1 year ago

Here's a PR implementing my feature request: https://github.com/dmamontov/hass-ledfx/issues/22

I went with the addition of a media_player entity. After all, LedFx is (kind of) a media player. Thought it would make more sense to put the play & pause feature into a media_player than in a switch. Also, we could add other new features like setting the global intensity (which could be the media_player "volume". Finally, the already existing feature of switching LedFx's audio source could be implemented in an async_select_source function of the media player.

For the coding style, I went straight to the point and didn't structure as well as the existing code. Let me know if you have suggestions to improve this.

Thanks :)

philcsn commented 1 year ago

Hey! Awesome work! Do you know if your fork still works with the current version of HA?

guix77 commented 1 year ago

Hi, thanks! Yes it does, I'm on the latest Home Assistant 2023.8.3 and LedFx v2.0.71

guix77 commented 10 months ago

This feature - and only this feature - is now available as a new integration: https://github.com/guix77/homeassistant-ledfx