search

dmandalidis / docker-client

A simple docker client for the JVM
Apache License 2.0
18 stars 9 forks source link

Dropping dependency on jnr-unixsocket #671

Closed akurtakov closed 23 hours ago

akurtakov commented 10 months ago

The project requires on the JNR stack for unixsocket but Java 16+ already provides native support. It would be nice to make use of it and drop this extra dependency from the dependency stack. Will the project be interested in such a patch?

dmandalidis commented 10 months ago

Hi @akurtakov ,

Thanks for opening this. Of course it would be interesting, feel free to open a PR.

Thanks again, Dimitris

akurtakov commented 10 months ago

Just as a hint what I did for Linux Tools project https://github.com/eclipse-linuxtools/org.eclipse.linuxtools/pull/290 . I may find time to try smth similar here too.

akurtakov commented 10 months ago

Unfortunately the the unixsocket support is implemented only at SocketChannel but not at Socket layer API. This seems to not fit at all with ConnectionSocketFactory. If you have some guidance what could be done in this case, please let me know.