search

dmandalidis / docker-client

A simple docker client for the JVM
Apache License 2.0
18 stars 9 forks source link

Fix ImageInfo message for Docker 25.0 #689

Closed LEDfan closed 9 months ago

LEDfan commented 9 months ago

Hi, first of all, many thanks for maintaining this fork. It is a great help for us!

With the release of Docker 25.0, the ImageInfo message no longer contains the VirtualSize field, see https://docs.docker.com/engine/api/version-history/ .

This PR makes the field nullable,so that it still works with older versions of docker.

dmandalidis commented 9 months ago

Hi, thanks for this and for the warm words. I ll check it out and let you know really soon

dmandalidis commented 9 months ago

Hi again, I have another PR open for docker update which has a couple of tests failing. I will work on this soon, and once merged I will let you know to rebase your branch

dmandalidis commented 9 months ago

Thanks a lot @LEDfan, I will release it within the day