dmansfield / parsey-mcparseface-api

Serve the Parsey McParseface API using TF Serving infrastructure
Apache License 2.0
36 stars 2 forks source link

@tf_serving//tensorflow_serving//session_bundle #3

Open abscondment opened 8 years ago

abscondment commented 8 years ago

First off, thanks for all of this work!

I'm following the current README exactly, but when I get to the build phase I encounter this error:

$ bazel build -c opt parsey_api/...
ERROR: /Users/brendan/code/foss-clones/nlp-api/parsey-mcparseface-api/parsey_api/BUILD:14:1: no such package '@tf_serving//tensorflow_serving/session_bundle': BUILD file not found on package path and referenced by '//parsey_api:parsey_api'.
ERROR: Loading failed; build aborted.
INFO: Elapsed time: 0.490s

I'm trying some of the other build suggestions mentioned in the other issues.

abscondment commented 8 years ago

Got things working! Two issues:

Here are the diffs I needed to make (excluding WORKSPACE):

diff --git a/syntaxnet/syntaxnet/BUILD b/syntaxnet/syntaxnet/BUILD
index 0289b60..2fe30ad 100644
--- a/syntaxnet/syntaxnet/BUILD
+++ b/syntaxnet/syntaxnet/BUILD
@@ -26,6 +26,7 @@ tf_proto_library(
 )

 tf_proto_library(
+    visibility = ["//visibility:public"],
     name = "sentence_proto",
     srcs = ["sentence.proto"],
 )
diff --git a/parsey_api/BUILD b/parsey_api/BUILD
index a0f3c72..75ae362 100644
--- a/parsey_api/BUILD
+++ b/parsey_api/BUILD
@@ -29,9 +29,7 @@ cc_binary(
         ":parsey_api_proto",
         "@tf_serving//tensorflow_serving/servables/tensorflow:session_bundle_config_proto",
         "@tf_serving//tensorflow_serving/servables/tensorflow:session_bundle_factory",
-        "@tf_serving//tensorflow_serving/session_bundle",
-        "@tf_serving//tensorflow_serving/session_bundle:manifest_proto",
-        "@tf_serving//tensorflow_serving/session_bundle:signature",
+        "@org_tensorflow//tensorflow/contrib/session_bundle",
+        "@org_tensorflow//tensorflow/contrib/session_bundle:signature",
     ],
 )
-
diff --git a/parsey_api/parsey_api.cc b/parsey_api/parsey_api.cc
index c878909..eda7bb1 100644
--- a/parsey_api/parsey_api.cc
+++ b/parsey_api/parsey_api.cc
@@ -27,9 +27,9 @@
 #include "parsey_api/parsey_api.pb.h"
 #include "tensorflow_serving/servables/tensorflow/session_bundle_config.pb.h"
 #include "tensorflow_serving/servables/tensorflow/session_bundle_factory.h"
-#include "tensorflow_serving/session_bundle/manifest.pb.h"
-#include "tensorflow_serving/session_bundle/session_bundle.h"
-#include "tensorflow_serving/session_bundle/signature.h"
+#include "tensorflow/contrib/session_bundle/manifest.pb.h"
+#include "tensorflow/contrib/session_bundle/session_bundle.h"
+#include "tensorflow/contrib/session_bundle/signature.h"

 #include "syntaxnet/sentence.pb.h"

diff --git a/parsey_client/api/syntaxnet/sentence.proto b/parsey_client/api/syntaxnet/sentence.proto
index 9e96e9a..270351f 120000
--- a/parsey_client/api/syntaxnet/sentence.proto
+++ b/parsey_client/api/syntaxnet/sentence.proto
@@ -1 +1 @@
-/data/tensorflow/opt/tensorflow/models/syntaxnet/syntaxnet/sentence.proto
\ No newline at end of file
+/Users/brendan/code/foss-clones/nlp-api/models/syntaxnet/syntaxnet/sentence.proto
\ No newline at end of file
diff --git a/parsey_client/index.js b/parsey_client/index.js
index 9162225..9711b64 100644
--- a/parsey_client/index.js
+++ b/parsey_client/index.js
@@ -2,9 +2,8 @@ var grpc = require('grpc');

 var protoDescriptor = grpc.load({root: __dirname+'/api', file:'cali/nlp/parsey_api.proto'});

-var service = new protoDescriptor.cali.nlp.ParseyService("127.0.0.1:9001", grpc.credentials.createInsecure());
+var service = new protoDescriptor.cali.nlp.ParseyService("127.0.0.1:9000", grpc.credentials.createInsecure());

 service.parse(["This is the first sentence", "I love this sentence"], function(err, response) {
        console.log(JSON.stringify(response,null,'  '));
 });
-