dmarc3 / vscode-nastran

Nastran Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mbakke.vscode-nastran&ssr=false
MIT License
7 stars 2 forks source link

Slow performance when working with VPN #69

Open T-solidus-T opened 7 months ago

T-solidus-T commented 7 months ago

Problem: Slow performance in functions like "Documentation on keyword hover" and interference with other extensions, for example with this extension to open files from the path of an include card "Open file https://marketplace.visualstudio.com/items?itemName=Fr43nk.seito-openfile"

Steps to reproduce

image

issue.zip

Info: VS Version: 1.85.2 OS: Windows_NT x64 10.0.19045

dmarc3 commented 7 months ago

Hey @T-solidus-T,

Thanks for submitting this issue. I suspect the issue isn't actually related to using the VPN or the "Open File" extension you linked but actually due to the Include Hierarchy load process being slow for a really large model like the one you're working with. The first thing this extension does when activating is populate the Include Hierarchy, which can be expensive because it needs to loop through all files to find all of the includes and build the tree.

If you were to disable the "Open File" extension and try to open the file again with this extension, does it take just as long? Or if you were to comment out all of the includes except 50 or so, does it take just as long? Also, how large is your model in terms of DOF or size of all the files combined if you can say? I've been able to load models with +300,000 grids reasonably quickly but those models usually only have on the order of ~50 different include files, not +500.

P.S. Out of curiosity, are you using the Include Hierarchy functionality at all or do you prefer to use the "Open File Under Cursor" context menu? I was unaware of the "Open File" extension and might look into adding that feature here or linking it as a dependency. Thanks for pointing it out!

T-solidus-T commented 7 months ago

Hi,

Yes I guess that you are right. I didn't mean that the problem is the VPN or the "open file" extension themselves but that the issue only appears when I am not working in my local drive. So probably the "Include Hierarchy" feature is being slow as it needs to load all the includes. When I'm connected to the VPN, it takes a bit due to the network speed limitation. But I don't understand why the nastran extension is blocking other VS extensions, maybe VS cannot manage multiple extensions at once?

Answering your questions:

Maybe it would be great if we have an option to enable/disable "include hierarchy" loading, that I think it will solve all the problems, don't you think so?