search

dmarcos / aframe-motion-capture-components

Capture entity motions and replay them on other entities
http://swimminglessonsformodernlife.com/aframe-motion-capture-components/
MIT License
132 stars 31 forks source link

avatar-replayer cannot be safely removed #23

Open wmurphyrd opened 7 years ago

wmurphyrd commented 7 years ago 
Error: Uncaught TypeError: Cannot read property 'removeComponent' of null 
.../aframe-motion-capture-components/src/components/avatar-replayer.js:218:0

I'm getting this error in test cleanup when using avatar-replayer, and it is reproducible in your replay.html example by calling removeComponent('avatar-replayer') on the scene entity after the replay has completed. Part of the issue is that isReplaying remains true even after replay is completed. Manually Setting this to false before attempting to remove the component allows for successful removal.

I'd be happy to contribute test cases, but I could not get half the existing tests to pass in a clone of the repo. Is that just on my end, or are those still in development?

ngokevin commented 7 years ago

The test cases are outdated yeah. Would love help and patches