search

dmarcos / aframe-motion-capture-components

Capture entity motions and replay them on other entities
http://swimminglessonsformodernlife.com/aframe-motion-capture-components/
MIT License
132 stars 31 forks source link

Updates for A-Frame v0.8.x compatibility #40

Closed wmurphyrd closed 6 years ago

wmurphyrd commented 6 years ago

Updates required for compatibility with changes to tracked controls system gamepad connection flow in A-Frame v0.8.0. Fixes #39

I believe it is still impossible to capture new recordings, but this patch allows me to successfully run my machinima tests for super-hands with current A-Frame versions.

  1. Bypass deprecated 'gamepadconnected' event
  2. Update tracked-controls system updateControllerList wrapping to overwrite the new throttledUpdateControllerList property
  3. Provide current real gamepad list to original updateControllerList as it no longer queries this on its own and doesn't clear out the controller list otherwise, sometimes preventing a recorded controller from activating when its index had been filled with a "finger" stub before it activated
wmurphyrd commented 6 years ago

Updated with a simpler wrapper for updateControllerList and a fix for controller object3D matrices not updating.

I ended up removing the "finger" controller mocks that were filling in gaps in the GamepadList. They were giving me trouble with preventing replaying controller components from activating by filling in their GamepadList slots before the controller replaying started. As tracked-controls is not preserving GamepadList indices and has checks to avoid performing operations on empty list members, I don't think this is still necessary. Let me know if I'm missing something

wmurphyrd commented 6 years ago

Something's not right with cleanup; back to that old too much recursion error in tests. WIP for now. Will update with fix

wmurphyrd commented 6 years ago

Ok cleanup issue is fixed. gtg

dmarcos commented 6 years ago

Thanks and sorry for the delay. I totally missed this.