search

dmarcos / aframe-motion-capture-components

Capture entity motions and replay them on other entities
http://swimminglessonsformodernlife.com/aframe-motion-capture-components/
MIT License
132 stars 31 forks source link

Consider a single webvr-recorder higher-order component #8

Closed ngokevin closed 7 years ago

ngokevin commented 7 years ago

Right now, we still have two components to add to do record + replay. They do deserve to be separate as they are in implementation, but the public API would be a tiny bit nicer if it was one component. You said you had plans for this, not sure if this is what you had in mind.

Perhaps just a single manager component: webvr-recorder or whatever name. (Sort of considering renaming avatar-* to webvr-*). This component could inject and set with defaults the record + play components, including UI.

<a-scene webvr-recorder="ui: true"></a-scene>

Edit: though I guess with the autoStart, avatar-recorder right now is a single step with localStorage.

ngokevin commented 7 years ago

avatar-recording seems to double as the master component