search

dmarkham / enumer

A Go tool to auto generate methods for your enums
Other
410 stars 66 forks source link

Add build constraints to the generated file #53

Open XanderAtBackboneSystems opened 2 years ago

XanderAtBackboneSystems commented 2 years ago

A simple solution for: https://github.com/dmarkham/enumer/issues/52

codecov-commenter commented 2 years ago

Codecov Report

Merging #53 (a36b9c2) into master (585d6b2) will decrease coverage by 0.35%. The diff coverage is 25.00%.

:exclamation: Current head a36b9c2 differs from pull request most recent head 6c12dd0. Consider uploading reports for the commit 6c12dd0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   66.23%   65.88%   -0.36%     
==========================================
  Files           4        4              
  Lines         465      469       +4     
==========================================
+ Hits          308      309       +1     
- Misses        146      149       +3     
  Partials       11       11
Impacted Files Coverage Δ
stringer.go 60.68% <25.00%> (-0.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 585d6b2...6c12dd0. Read the comment docs.

XanderAtBackboneSystems commented 2 years ago

Hello @dmarkham , I need a bit of help... I'm not sure what the problem is.

The first commit reduce the test coverage. So i added a test which also test other features (comments) that weren't tested so the test coverage should be enough now. When i run the coverage tool of my IDE i'm well above the minimal coverage of the main branch.

Any help would be appreciated...

best regards Xander

dmarkham commented 2 years ago

Hello @dmarkham , I need a bit of help... I'm not sure what the problem is.

The first commit reduce the test coverage. So i added a test which also test other features (comments) that weren't tested so the test coverage should be enough now. When i run the coverage tool of my IDE i'm well above the minimal coverage of the main branch.

Any help would be appreciated...

best regards Xander

It's fine I'm not that worried about the coverage... it's more a goal than a rule.