search

dmarnerides / hdr-expandnet

Training and inference code for ExpandNet
Other
201 stars 40 forks source link

Not working at all #20

Closed ghost closed 1 year ago

ghost commented 1 year ago

It gives same LDR output

dmarnerides commented 1 year ago

What do you mean?

On Tue, 1 Aug 2023, 07:45 Avi, @.***> wrote:

It gives same LDR output

— Reply to this email directly, view it on GitHub https://github.com/dmarnerides/hdr-expandnet/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2A5HNIJEKKHZJRVXFNQODXTCCWZANCNFSM6AAAAAA27FSHTQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ghost commented 1 year ago

When I give a .jpg input, it gives a .hdr output. But it does not have a High Dynamic Range, it is the same as the jpg just in hdr format. Can you please help me to get it working? I would be much obliged.

dmarnerides commented 1 year ago

I think if you get the HDR it means it's working. Not sure what exactly the problem is. The .hdr is linearised, without gamma, without CRF and needs tone mapping to get back to the LDR.

There won't be expansion (hallucination) in the under/overexposed areas as that was not in the scope of the project.

For more information have a look at the paper linked in the README page.

On Tue, 1 Aug 2023, 09:01 Avi, @.***> wrote:

When I give a .jpg input, it gives a .hdr output. But it does not have a High Dynamic Range, it is the same as the jpg just in her format. Can you please help me to get it working? I would be much obliged.

— Reply to this email directly, view it on GitHub https://github.com/dmarnerides/hdr-expandnet/issues/20#issuecomment-1659620756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2A5HKBXXIKFBHNWJDWUP3XTCLU7ANCNFSM6AAAAAA27FSHTQ . You are receiving this because you commented.Message ID: @.***>

ghost commented 1 year ago

https://we.tl/t-mmz0jJfFBr

have a look here. it has a input file and the output i get from your code.

ghost commented 1 year ago

In the git description, as you mentioned it takes a ldr input and gives a hdr output

image

I am just trying to do that, could you please help me in this...... please...

dmarnerides commented 1 year ago

I'm sorry, I can't help you more than what I already have described.

I would suggest that you read up on HDR literature and come back to this.

On Tue, 1 Aug 2023, 09:11 Avi, @.***> wrote:

In the git description, as you mentioned it takes a ldr input and gives a hdr output

[image: image] https://user-images.githubusercontent.com/33053458/257421182-e58ac563-6bd7-4b24-85f7-68a631d937e5.png

I am just trying to do that, could you please help me in this...... please...

— Reply to this email directly, view it on GitHub https://github.com/dmarnerides/hdr-expandnet/issues/20#issuecomment-1659629563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2A5HPMIWMTHFIX5J35QWTXTCMZTANCNFSM6AAAAAA27FSHTQ . You are receiving this because you commented.Message ID: @.***>

ghost commented 1 year ago

Can you explain what exactly is your code doing instead of just changing the extension from jpg to hdr?

dmarnerides commented 1 year ago

If you simply change a .jpg to .hdr it won't be like this. All the information about what the code is doing is here:

https://arxiv.org/abs/1803.02266

I'm closing the issue as this isn't an actual issue.