10 implement configuration and basic logging

dmarro89 / dare-db

Dare-DB is a lightweight in-memory database written in Go, featuring Redis-inspired hashtables and HTTP/HTTPS endpoints for seamless data storage and retrieval, with Docker support for easy deployment

MIT License

16 stars 1 forks source link

10 implement configuration and basic logging #18

Closed vdmitriyev closed 3 weeks ago

vdmitriyev commented 3 weeks ago

Based on the discussion - https://github.com/dmarro89/dare-db/discussions/8

Changes:

New configuration with viper using "TOML" format
Adding tests for the new configuration
Adapt existing test for the new configuration feature
Remove old configuration feature
Add basic loggig with custom formatter

New dependencies:

github.com/spf13/viper
github.com/sirupsen/logrus
github.com/stretchr/testify

Change .gitignore file and exclude generated files

dmarro89 commented 3 weeks ago

Thanks for your contribution @vdmitriyev. It's a good PR. I've added some comments just to keep the code flexible and maintainable - using dependency injection and maybe removing external dependencies.

vdmitriyev commented 3 weeks ago

@dmarro89 thank you for your fast response. I tried to respond to your comments you provided. The idea with the logger that uses log/slog could be re-implemented as part of another issue. That is why I just named it as "basic-logging" in this PR.

vdmitriyev commented 3 weeks ago

Thank you for accepting this PR. I had closed the issues attached to it as well - https://github.com/dmarro89/dare-db/issues/9