dmarro89 / dare-db

Dare-DB is a lightweight in-memory database written in Go, featuring Redis-inspired hashtables and HTTP/HTTPS endpoints for seamless data storage and retrieval, with Docker support for easy deployment
MIT License
16 stars 1 forks source link

Error while starting with Docker #30

Closed dmarro89 closed 1 week ago

dmarro89 commented 1 week ago

Hi @vdmitriyev, I'm trying to start the DB using docker but when i try to send an http request to it, the server refuses the connection. While if I try to start the application in debug from VSCode, there's no problem. Have you tried to start it from docker ?

dmarro89 commented 1 week ago

Fixed here -> https://github.com/dmarro89/dare-db/pull/31 @vdmitriyev

vdmitriyev commented 1 week ago

Before accepting your previous PR I had tried the TLS version of the Docker and it worked well

vdmitriyev commented 1 week ago

@dmarro89 I am going to try our your latest PR and let you know

dmarro89 commented 1 week ago

@dmarro89 I am going to try our your latest PR and let you know

The problem was on the http server. Let me fix the pipeline and then you can try it.

dmarro89 commented 1 week ago

@vdmitriyev fixed

vdmitriyev commented 1 week ago

@dmarro89 thanks. It runs and tests work fine. However, I have some concerns regarding 0.0.0.0 as a default value for host and usages of environmental variables. Please, see other comments attached to your code.

dmarro89 commented 1 week ago

@dmarro89 thanks. It runs and tests work fine. However, I have some concerns regarding 0.0.0.0 as default value for host and environmental variables. Please, see other comments attached to your code.

Ok thanks

dmarro89 commented 1 week ago

@dmarro89 thanks. It runs and tests work fine. However, I have some concerns regarding 0.0.0.0 as a default value for host and usages of environmental variables. Please, see other comments attached to your code.

Hi @vdmitriyev I don't see any comment on the code, am I wrong?

vdmitriyev commented 1 week ago

@dmarro89 thanks. It runs and tests work fine. However, I have some concerns regarding 0.0.0.0 as a default value for host and usages of environmental variables. Please, see other comments attached to your code.

Hi @vdmitriyev I don't see any comment on the code, am I wrong?

It is strange. Because I provided some comments.

dmarro89 commented 1 week ago

@dmarro89 thanks. It runs and tests work fine. However, I have some concerns regarding 0.0.0.0 as a default value for host and usages of environmental variables. Please, see other comments attached to your code.

Hi @vdmitriyev I don't see any comment on the code, am I wrong?

It is strange. Because I provided some comments.

Maybe you have started a review but non clicked on comment at the end of it.

vdmitriyev commented 1 week ago

@dmarro89 thanks. It runs and tests work fine. However, I have some concerns regarding 0.0.0.0 as a default value for host and usages of environmental variables. Please, see other comments attached to your code.

Hi @vdmitriyev I don't see any comment on the code, am I wrong?

It is strange. Because I provided some comments.

Maybe you have started a review but non clicked on comment at the end of it.

Now I mentioned you explicitly in the comments. Could you please confirm, that you can see them?

vdmitriyev commented 1 week ago

PR was merged https://github.com/dmarro89/dare-db/pull/31 Issue will be closed