dmarx / ComfyUI-Keyframed

ComfyUI nodes to facilitate prompt/parameter keyframing
MIT License
86 stars 7 forks source link

fixed bugs resulting from mutated objects #13

Closed dmarx closed 10 months ago

dmarx commented 10 months ago

two cases were causing unexpected behaviors:

  1. changing the order in which arithmetic operations on conditionings were performed changed the output
  2. rerunning the workflow with inconsequential changes could result in significantly different (and corrupted) outputs

the issue lies in how the backend passes objects around and tries to pass already-built objects back to mitigate recomputation. the general strategy to avoid this issue is to make copies of any inputs that there is any risk of mutating before operating on them.