search

dmarx / keyframed

Simple, expressive, pythonic datatypes for manipulating curves parameterized by keyframes and interpolators.
36 stars 1 forks source link

readme demo broken #69

Closed dmarx closed 1 year ago

dmarx commented 1 year ago

noticed when trying to reproduce issue here: https://github.com/dmarx/keyframed/issues/52

dmarx commented 1 year ago

last working release was v0.3.0, breaks in v0.3.1 so probably some issue introduced with serialization

dmarx commented 1 year ago

https://github.com/dmarx/keyframed/compare/v0.3.0...v0.3.1

dmarx commented 1 year ago

calling the pg = params change on line 323 the most likely culprit https://github.com/dmarx/keyframed/compare/v0.3.0...v0.3.1#diff-e0d4dbdc13ca03d4b8ee8f590b00bad1c2cdd997bf7b7cde69020171dd24ce42R323

dmarx commented 1 year ago

all the more reason to separate the Composition type from a ParameterComposition type or whatever. CompositionGroup, I dunno.

dmarx commented 1 year ago

issue had to do with auto-labeling of compositions. fixed with v0.3.5