dmarx / video-killed-the-radio-star

Notebook and tools for end-to-end automation of music video production with generative AI

https://colab.research.google.com/github/dmarx/video-killed-the-radio-star/blob/main/Video_Killed_The_Radio_Star_Defusion.ipynb#scrollTo=oPbeyWtesAoh

MIT License

196 stars 35 forks source link

did have this working now i get same problem every time #131

Closed sheriffdude closed 1 year ago

sheriffdude commented 1 year ago

TypeError Traceback (most recent call last) in <cell line: 155>() 216 with open(outpath,'w') as f: 217 # to do: upstream PR to control verbosity --> 218 writer.write_result( 219 whispers[k], 220 file=f,

TypeError: write_result() missing 1 required positional argument: 'options'

any help on this i have tried different videos with no luck .i did make 2 videos with this ..now even using the same link to a video same error

MWMullowney commented 1 year ago

I’m getting the same error. Fix was listed under a separate similar issue. You need to change the whisper options to this:

    options = dict(
        highlight_words=False,
        max_line_width=None,
        max_line_count=None
        )

...and the "writer.write_result" line under the "save transcriptions" section:

        writer.write_result(
            whispers[k],
            f,
            options
        )

MWMullowney commented 1 year ago

It's still pretty touchy. I had to restart the runtime occasionally throughout to get all the way through.

On Tue, Apr 18, 2023 at 12:32 PM cupcakev3 @.***> wrote:

writer.write_result(
    whispers[k],
    f,
    options
still giving me an error

— Reply to this email directly, view it on GitHub https://github.com/dmarx/video-killed-the-radio-star/issues/131#issuecomment-1513555154, or unsubscribe https://github.com/notifications/unsubscribe-auth/APYTWBVKVRIMVBHPMYKXDP3XB3F2TANCNFSM6AAAAAAW5MCUAU . You are receiving this because you commented.Message ID: @.***>

MWMullowney commented 1 year ago

This replaces the current "options" code within this section:

💬 Transcribe and segment speech using whisper

Replace this with what I shared:

    options = whisper.DecodingOptions(
        language='en',
    )

On Tue, Apr 18, 2023 at 11:32 AM cupcakev3 @.***> wrote:

maybe this is a dumb question but where do you specifically insert options = dict( highlight_words=False, max_line_width=None, max_line_count=None )

— Reply to this email directly, view it on GitHub https://github.com/dmarx/video-killed-the-radio-star/issues/131#issuecomment-1513472358, or unsubscribe https://github.com/notifications/unsubscribe-auth/APYTWBRVNJBYVB4SMPW3OVTXB262HANCNFSM6AAAAAAW5MCUAU . You are receiving this because you commented.Message ID: @.***>