search

dmathieu / glynn

Unmaintained. See the README - Generate your jekyll blog files and sends them through FTP
MIT License
359 stars 56 forks source link

Replace CLI usage with HighLine calls #50

Closed sionleroux closed 8 years ago

sionleroux commented 8 years ago

This shouldn't change anything from the user's perspective but makes the code a bit more straightforward to read. Since we're already using HighLine, I thought I might as well use it everywhere. Notably this let's us get rid of the try-catch block when reading the password (as far as I can tell that's all it was there for), so it's worth looking at this commit disregarding white space changed git show -w because removing the surrounding block meant re-indenting the logic that was inside.

Since it's also easy to set colours with HighLine I had the success messages output in green.

I tried it out and it looks good.

dmathieu commented 8 years ago

That is an awesome idea. Thank you!

The pinned version of rb-inotify has been yanked. I just fixed it in master. Could you rebase your branch so travis can pass?

sionleroux commented 8 years ago

Done, tests passing :+1:

dmathieu commented 8 years ago

Thank you. :tulip: