Closed zwalker closed 8 years ago
Is there a reason for keypress.js
being removed from the repo with this PR? Seems like the currently published version 2.1.4 is broke because it is pointing to keypress.js
as entry point which is now missing.. @dmauro
It's been a while, but no I don't think I intended to remove it. I just intended to re-generate it since the coffee script had changed.
On Fri, Dec 2, 2016 at 12:10 AM, ClemensSchneider notifications@github.com wrote:
Is there a reason for keypress.js being removed from the repo with this PR? Seems like the currently published version 2.1.4 is broke because it is pointing to keypress.js as entry point which is now missing.. @dmauro https://github.com/dmauro
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dmauro/Keypress/pull/118#issuecomment-264397255, or mute the thread https://github.com/notifications/unsubscribe-auth/AA62lrk6wgdZSSRoNotjkFckqiCzrfNSks5rD9J0gaJpZM4JM4sl .
The value of "this" being used previously was bound to the window and not to the keypress listener.