bug: meta combos are not being unregistered

dmauro / Keypress

A keyboard input capturing utility in which any key can be a modifier key.

http://dmauro.github.io/Keypress/

Apache License 2.0

3.18k stars 313 forks source link

bug: meta combos are not being unregistered #133

Closed bichotll closed 6 years ago

bichotll commented 7 years ago

Hi, I came across with an annoying bug. Shortcuts with "meta" can not be unregistered. At first I thought it was a problem with my script :/

In any case, I've created a demo so you can reproduce it: http://jsbin.com/xajipev/edit?html,js,console,output On it you can register/unregister 2 meta/ctrl shortcuts and compare the result/behaviour with the console.

I will review it myself if I have any time...

mhuebert commented 7 years ago

I want to include Keypress in a little comparison between different keybindings libraries I'm making: https://keys-test.lark.cloud/?library=Combokeys&keystring=M1%2520s

but I can't include it because of this bug, it interferes with the other libs when you can't unbind things.

mhuebert commented 7 years ago

I have created PR #137 to fix this issue.

dmauro commented 6 years ago

Will be fixed in the .5 release