search

dmauro / Keypress

A keyboard input capturing utility in which any key can be a modifier key.
http://dmauro.github.io/Keypress/
Apache License 2.0
3.18k stars 313 forks source link

No tag for 1.0.8 #20

Closed afc163 closed 11 years ago

afc163 commented 11 years ago 
git tag 1.0.8

That would be helpful, thx!

ConnorKrammer commented 11 years ago

I would like to second this. Then we could use it from Bower without having to run off of the master repository (where breaking changes may occur).

dmauro commented 11 years ago

Oh, great idea. Done and thank you.

ConnorKrammer commented 11 years ago

Running bower install Keypress#1.0.8 is still giving me the error bower ENORESTARGET No tag found that was able to satisfy 1.0.8. So Bower is still searching the git repository for an actual tag. I'm not sure why bower.json isn't being looked at -- my best guess is that running git tag 1.0.8 is the easiest way to resolve this.

Oh, and a sidenote. Found this in the Bower spec document:

main [string|array of strings]

The primary acting files necessary to use your package. While Bower does not directly use these files, they are listed with the commands bower list --json and bower list --paths, so they can be used by build tools. Do not include minified files. Files should not be versioned (Bad: package.1.1.0.js; Good: package.js).

(emphasis added)

Don't know if you care about that, but thought you'd like to know.

dmauro commented 11 years ago

Good to know about the main tag. I didn't look closely enough at that I guess.

I did do git tag, not sure why it's not taking. Could just take some time for Bower to play catch up? edit: I just tried bower install Keypress#1.0.8 and it went off without a hitch.

cbebry commented 11 years ago

I noticed that there are no tags in the GitHub list of tags for this repository. Is it possible that the tags have not been pushed up?

git push --tags

dmauro commented 11 years ago

Yeah, that was it. Thanks.

ConnorKrammer commented 11 years ago

Didn't notice that you'd just replied, and was trying it again myself.

My response: "WTF? This was broken 30 seconds ago!"

Great that it worked out.

dmauro commented 11 years ago

Well the weird thing is the install worked for me BEFORE I did git push --tags. :?

ConnorKrammer commented 11 years ago

Eh, I guess we'll never know. It's just one of those things.

abhikmitra commented 10 years ago

This problem suddenly appearing now. Anybody getting it ?