search

dmauro / Keypress

A keyboard input capturing utility in which any key can be a modifier key.
http://dmauro.github.io/Keypress/
Apache License 2.0
3.18k stars 313 forks source link

IE single key press alongside meta combination #26

Closed jacquestvanzuydam closed 10 years ago

jacquestvanzuydam commented 10 years ago

I'm seeing unexpected behaviour in IE, where I have a single key as a shortcut, but also have another shortcut that uses the single key as well as the meta key. On other browsers it seems fine (fires both events separately), but on IE it is firing both events, the combination first and then the single key. I'm testing on a Windows 8 virtual machine, with IE10.

dmauro commented 10 years ago

Hmmm, unless you are using the "is_exclusive" property on both combos, they should both be firing. What do you mean exactly by "fires both events separately"? Could you give a code sample of your combo definitions.

jacquestvanzuydam commented 10 years ago

Single Key shortcut: keypress.combo('z', function(event) { console.log('z'); }, false);

Combination Shortcut: keypress.combo('meta z', function(event) { console.log('meta z'); }, false);

Works fine in every browser except for IE. Pressing "CTRL Z" outputs both "z" and "meta z" to the console in IE one after the other. I'll be honest, I haven't yet tried creating the combos using the other methods, but see it as a bug in IE.

jacquestvanzuydam commented 10 years ago

I used the register_combo method and this fixed my bug, just a side note: you're missing a coma in your example on the website: after the "is_exclusive" : false line. My apologies regarding the "non-bug", your keypress library is by far the best I've come across when it comes to key capturing.