search

dmauro / Keypress

A keyboard input capturing utility in which any key can be a modifier key.
http://dmauro.github.io/Keypress/
Apache License 2.0
3.18k stars 313 forks source link

Fixed key_down not fired up when 2 combos are exclusive #73

Closed Canardlaquay closed 9 years ago

Canardlaquay commented 9 years ago

From issue https://github.com/dmauro/Keypress/issues/72

Canardlaquay commented 9 years ago

(Second commit is a typo, sorry)

dmauro commented 9 years ago

Hey, sorry this is a little imperfect, but this is by design. The 's' is also in the 'shift s' combo so we shouldn't fire the 's' combo because we might be working towards the 'shift s' combo.

One thing I could do is because the 'shift s' is "blocking" the 's' combo and we know the 'shift s' combo is ordered, we could check for that and not block it.

Thanks for taking a stab at it though. I'm going to reopen the issue and mark it for enhancement.