search

dmbaturin / pytaf

TAF (Terminal Aerodrome Forecast) and METAR parser and decoder
MIT License
57 stars 23 forks source link

Fixed PROB TEMPO group handling #4

Closed cayetanobv closed 9 years ago

cayetanobv commented 9 years ago

I fixed PROB TEMPO group handling, which until now was not included. I followed the specification of ICAO ANNEX III (Table A5-2. Use of change and time indicators in TAF).

Test examples: TAF LEZL 182000Z 1821/1921 18006KT 9999 SCT030 TX26/1915Z TN18/1906Z TEMPO 1900/1909 BKN012 PROB40 TEMPO 1902/1909 4000 RA PROB40 TEMPO 1912/1918 4000 SHRA SCT020TCU

TAF LEZL 182000Z 1821/1921 18006KT 9999 SCT030 TX26/1915Z TN18/1906Z PROB40 1902/1909 4000 RA TEMPO 1900/1909 BKN012 PROB40 TEMPO 1902/1909 4000 RA PROB40 TEMPO 1912/1918 4000 SHRA SCT020TCU

dmbaturin commented 9 years ago

Nice! Do you have a link to the Annex 3 document? Also, I think we should add some automated tests.

cayetanobv commented 9 years ago

If you search in a web browser "Annex 3 ICAO" the first link goes to a PDF file (is a link to WMO website), but this is not the last version (last update was in 2013). I searched for a link but I have not found. I have the updated document and I can send you by email (14 Mb) if you want. I would like to add some automated tests (great idea!). I'll try to do when I find the time. Thanks for all!

dmbaturin commented 9 years ago

Yeah, I couldn't find the recent version either. If you have it, please email it to me (the email in commits is the actual one). Message size limit is configured to 20Mbyte or so, so this will work, although compressing it won't harm.

cayetanobv commented 9 years ago

Ok, I sent you the document by email.

dmbaturin commented 9 years ago

Thanks!