search

dmcallejo / ASFBot

Control your ArchiSteamFarm with Telegram
GNU General Public License v3.0
43 stars 10 forks source link

fixing some bugs in bot.py and readme. #18

Closed zanderzhng closed 8 months ago

zanderzhng commented 8 months ago

I found it still have problems using environments. Using args are ok. Can you help investigate it? Or I will research it later.

dmcallejo commented 8 months ago

I don't use a proxy to reach the Telegram servers so I can't really test your development, but I think it's a feature which might be useful for many people. Please take your time to fix your code and I will happily merge it.

The problem with the env var might be related to escaping special characters. You might also want to specify how to differentiate an http or https (or socks for example) proxy and not adding the same proxy as every available protocol :)

zanderzhng commented 8 months ago

Hello @dmcallejo, I have ran tests with both args and envs, both work, the problem came from my proxy actually. I was using a mixed port proxy (combining http and socks5 port) which caused problems. If I use http proxy port, it works well.

dmcallejo commented 8 months ago

Hello, I see in the Readme that you've pointed out that only http proxies are accepted, but in the code you're setting the given proxy both as http and https. Is that all right?

What do you think about inputting the proxy as http://myproxy:8080, https://myproxy:8080, socks5://myproxy:8080, etc. using <protocol>://<host>:<port> nomenclature.