dmcbrn / laravel-email-database-log

A simple database logger for all outgoing emails sent by Laravel website.
MIT License
15 stars 12 forks source link

Support for Laravel 9 #12

Open tmbenhura opened 1 year ago

tmbenhura commented 1 year ago

Attempting to install gives an error:

Problem 1

dmcbrn commented 1 year ago

Sorry I keep missing these.

Easiest to resolve this by forking the library and in composer.json replace

"require": {
        "illuminate/support": "~8.0",
        "illuminate/database": "~8.0",
        "illuminate/mail": "~8.0",
        "illuminate/queue": "~8.0",
        "doctrine/dbal": "*"
    },

with

"require": {
        "illuminate/support": "~8.0 || ~9.0",
        "illuminate/database": "~8.0 || ~9.0",
        "illuminate/mail": "~8.0 || ~9.0",
        "illuminate/queue": "~8.0 || ~9.0",
        "doctrine/dbal": "*"
    },

There shouldn't be any breaking changes. Let me know if it works or not.

Leaving links for reference:

https://getcomposer.org/doc/articles/versions.md#tilde-version-range- https://getcomposer.org/doc/articles/versions.md#version-range

I guess the range could be updated to ~5.0 || ~6.0 || ~7.0 || ~8.0 || ~9.0 || ~10.0 but I don't have time to test it all out.

tmbenhura commented 1 year ago

In semantic versioning, minor versions, introduce backwards compatible changes. This means that any features the package depends on should still work correctly.

https://semver.org/

On Tue, 21 Mar 2023, 03:45 dmcbrn, @.***> wrote:

I just realized it needs to be ~ as minor versions introduce breaking changes.

— Reply to this email directly, view it on GitHub https://github.com/dmcbrn/laravel-email-database-log/issues/12#issuecomment-1477169566, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADS2454YNNU6ICANKXRAJF3W5EB5DANCNFSM6AAAAAAQRQCWFI . You are receiving this because you authored the thread.Message ID: @.***>

dmcbrn commented 1 year ago

Yup, I realized I mixed up few things in my head and deleted the comment few minutes later. It was very late in my defense.

There are possible issue with adding L9 support: https://github.com/dmcbrn/laravel-email-database-log/pull/14#issuecomment-1477438156

Leaving open until I have time to test it out in L9.