search

dmcc / PyStanfordDependencies

Python interface for converting Penn Treebank trees to Stanford Dependencies and Universal Depenencies
https://pypi.python.org/pypi/PyStanfordDependencies
68 stars 17 forks source link

Add Python 3 support #4

Closed dmcc closed 9 years ago

smartschat commented 9 years ago

For a Python 3 project of mine I needed Stanford Dependencies and made your package Python 3 compatible. All unit tests pass under Python 2.7.3 and Python 3.3.5. How is the status of this issue, should I fork this repository and put my modifications online?

dmcc commented 9 years ago

Awesome! AFAIK, nobody else has worked on this issue and there's no major restructuring in progress, so this is a perfect time to check it in. Please fork and make a pull request.

By the way, I should say that IBM requires me have all contributors sign a contributor license agreement before merging changes:

    https://www.dropbox.com/s/woyyhxej4y0t2rw/cla-individual-PyStanfordDependencies.rtf?dl=1

Please email me if you have any questions about it (and apologies -- I've been meaning to add a CONTRIBUTING.md file with this information so potential contributors would know about it upfront. I'll add one later today).

dmcc commented 9 years ago

Added by @smartschat in https://github.com/dmcc/PyStanfordDependencies/pull/12.