search

dmchale / disable-json-api

Public repo for the "Disable REST API" WordPress plugin, currently with 90,000+ active installs in the wordpress.org repository
10 stars 9 forks source link

Dead code: `Disable_REST_API::load_plugin_textdomain` #20

Closed tangrufus closed 7 years ago

tangrufus commented 7 years ago

Disable_REST_API::load_plugin_textdomain condition never true because that class never run on WP 4.6 or below.

https://github.com/dmchale/disable-json-api/blob/182453636ccfba2057a42a896d8d9d457c8d17ad/disable-json-api.php#L26

https://github.com/dmchale/disable-json-api/blob/182453636ccfba2057a42a896d8d9d457c8d17ad/classes/disable-rest-api.php#L44

dmchale commented 7 years ago

Hah! I knew something was bothering me about that code, but I couldn't pin down what/why. That was it Removed: https://github.com/dmchale/disable-json-api/commit/30ca58248d05752fd3a24cbbccc76d9613c345e4