search

dmchale / disable-json-api

Public repo for the "Disable REST API" WordPress plugin, currently with 90,000+ active installs in the wordpress.org repository
10 stars 9 forks source link

Add textdomain #24

Closed tangrufus closed 6 years ago

dmchale commented 6 years ago

I don't think we need to add the textdomain to the esc_attr() on line 176 (and we'd probably want to update the function to esc_attr__() if we did, since esc_attr() only takes a single string parameter...)

Do you want to update this to only add the textdomains to both of the esc_html__() functions, and I'll merge it in?

tangrufus commented 6 years ago

Updated. The esc_attr__() part was a mistake.

dmchale commented 6 years ago

No worries, and nice catch on adding the texdomain to those 2 functions