search

dmchale / disable-json-api

Public repo for the "Disable REST API" WordPress plugin, currently with 90,000+ active installs in the wordpress.org repository
10 stars 9 forks source link

Using `filemtime` to cache bust editor assets is not reliable #29

Closed tangrufus closed 3 years ago

tangrufus commented 3 years ago

https://github.com/dmchale/disable-json-api/blob/5e5bf4cc0cde163e2b0e6445c15a868c58f3e3af/classes/disable-rest-api.php#L192-L194

See: https://github.com/WordPress/gutenberg/issues/18227

dmchale commented 3 years ago

cheers @TangRufus ! Wasn't aware this was a frowned-upon pattern nowadays, using the plugin version makes sense though.

tangrufus commented 3 years ago

Looks good to me. 🎉