Refactor digirom types - Githubissues

dmcomm / dmcomm-python

MIT License

6 stars 0 forks source link

Refactor digirom types #30

Closed dmcomm closed 1 year ago

dmcomm commented 1 year ago

core_words has undesirable copy-and-paste programming from core_bytes, and there is some other duplication. Probably need to remove classmethod from_string from the API and replace the constructors.

dmcomm commented 1 year ago

If we're breaking the API anyway, it would be a good time to move and/or rename the digirom types as I was thinking about recently.

dmcomm commented 1 year ago

Make ClassicDigiROM inherit from BaseDigiROM (they are pretty close now)
Create a BaseResultSegment - subclasses implement str_data and null_value
Create a shared helper function for from_string in BytesCommandSegment and WordsCommandSegment
~~Add BaseDigiROM.from_string~~ Add an option to BaseDigiRom.__init__ to take string segments.