search

dmcquay / node-apac

node-apac - Node.js client for the Amazon Product Advertising API, including support of Request Signatures
MIT License
499 stars 111 forks source link

Added optional callback to handle errors #42

Closed MatAtBread closed 10 years ago

MatAtBread commented 10 years ago

Required to be able to cleanly end outstanding requests in Node if an underlying service barfs.

The change relies on a new, optional fourth parameter and shouldn't break anything at all.

dmcquay commented 10 years ago

Thanks matt. Looks like a helpful change.

MatAtBread commented 10 years ago

Glad I could help. If you get around to re-publishing on npmjs let me know and I'll kill my fork - I have plenty of other stuff to be doing :)

WesleyYue commented 10 years ago

I'll merge and republish on npm when I get home tonight.