search

dmcquay / node-apac

node-apac - Node.js client for the Amazon Product Advertising API, including support of Request Signatures
MIT License
499 stars 111 forks source link

Added option xml2jsOptions #44

Closed ck86 closed 10 years ago

dmcquay commented 10 years ago

Can you explain the use case for passing these options? In any case, it seems like a good idea to allow them to be passed. I'm just curious if there's a common use case that we should handle automatically so that you don't have to pass any options.

ck86 commented 10 years ago

I don't like the default conversion of the xml2js module. So I wanted to add the option explicitArray which is currently not possible. Instead of hardcoding it you can now add your own xml2js options, if you like.

dmcquay commented 10 years ago

Thanks ck86. I'll let WesleyYue make the call on the merge, but it looks good to me.

WesleyYue commented 10 years ago

Looks good, I'll merge and update the documentation on the readme.