dmcquay
commented
8 years ago First of all, I don't think you need all of those properties. Your code should behave identical if you write it like this:
function runQueries(queryArray) {
for (var i = 0; i < queryArray.length; i++) {
opHelper.execute('ItemSearch', queryArray[i], function (err, results) {
if (err) {
// handle err
} else {
//save each item in a MongoDB and delete it after server shutdown...
}
})
}
}The best way to tackle this problem is using promises. I would first wrap the opHelper execute method in a promise like this:
function executeQuery(query) {
return new Promise(function (resolve, reject) {
opHelper.execute('ItemSearch', newQuery, function (err, results) {
if (err) return reject(err)
resolve(results)
})
})
}Then you can implement your function as simply as this:
function runQueries2(queryArray) {
let promises = queryArray.map(query => executeQuery(query))
return Promise.all(promises)
}Keep in mind that since this is now using promises, you'll need to call your function like this:
runQueries2(queryArray).then((results) => {
// save to mongo or whatever...
}).catch((err) => {
// console.log or whatever
})I am in the process of updating this module to provide support for Promises out of box so that you won't have to create your own wrapper like I have done here.
Hucho
Hallo,
first thank you for the great module...it is working fine.
My problem is that the "for loop" runs and executes queries too fast/async while the callback is much slower. Would it be possible to patch the module in a way that i can set a interval parameter in ms. Do you have another idea to fix the problem?
Thanks
Hucho