search

dmdedup / dmdedup3.19

Device-mapper Deduplication Target
20 stars 11 forks source link

Save statistics in CBT backend #34

Closed vinothkumarraja closed 7 years ago

vinothkumarraja commented 7 years ago

Implemented set_private_data and get_private_data functions to save physical and logical block counters

sectorsize512 commented 7 years ago

Thanks, I like this patch more. But it is still not ideal :)

Let's talk about the semantics of set_private_data() and set_private_data() methods. Dmdedup expects that any backend will store whatever data that is passed set_private_data() without looking into it. I.e., a specific sequence of bytes is just stored by a backend and is guranteed to be returned later if get_private_data() is called. In you case, however, CBT backend looks inside the data and expects it in a certain format. This should not be the case. I.e., CBT backend should just store the raw sequence of bytes, leaving the interpretation of those to core Dmdedup itself.