dmdedup / dmdedup3.19

Device-mapper Deduplication Target
20 stars 11 forks source link

Fix to properly access bio_vecs using bi_iter via macros in read-modify-write code path #7

Closed venkrishr closed 8 years ago

venkrishr commented 8 years ago

Replaced direct accesses to bi_io_vec with appropriate macros

venkrishr commented 8 years ago

No. It looks fine on my editor. Don't know why it shows like this in the diff.

ezk commented 8 years ago

It’s wrong in the patch itself.

The first line has a TAB char. The second one has 4 spaces instead. You should be careful: configure your text editor for “standard” linux/c editing style, which uses TABs. In Emacs it’s

CTRL-c . linux

(note “.” after Control-C)

Run ./scripts/checkpatch.pl with right args on EVERY patch before you submit it, and fix any warnings/errors checkpatch.pl reports. Indentation is one of them.

Thanks, Erez.

On Apr 29, 2016, at 12:13 PM, Venkatakrishnan notifications@github.com wrote:

No. It looks fine on my editor. Don't know why it shows like this in the diff.

venkrishr commented 8 years ago

Sure.