Closed venkrishr closed 8 years ago
No. It looks fine on my editor. Don't know why it shows like this in the diff.
It’s wrong in the patch itself.
The first line has a TAB char. The second one has 4 spaces instead. You should be careful: configure your text editor for “standard” linux/c editing style, which uses TABs. In Emacs it’s
CTRL-c . linux
(note “.” after Control-C)
Run ./scripts/checkpatch.pl with right args on EVERY patch before you submit it, and fix any warnings/errors checkpatch.pl reports. Indentation is one of them.
Thanks, Erez.
On Apr 29, 2016, at 12:13 PM, Venkatakrishnan notifications@github.com wrote:
No. It looks fine on my editor. Don't know why it shows like this in the diff.
Sure.
Replaced direct accesses to bi_io_vec with appropriate macros