dmdevgo / RxPM

Reactive implementation of Presentation Model pattern in Android.
Other
183 stars 18 forks source link

Integrated support for permissions processing #30

Open dmdevgo opened 6 years ago

dmdevgo commented 6 years ago

RxPM focuses on solving practical problems of the presentation layer. Such features as DialogControl or dispatching of navigation messages save us of many problems and boilerplate code. Processing of permissions is the same problem. Although there are many libraries, like RxPermissions, but many difficulties arise when trying to embed them in the PresentationModel. So I think it would be convenient to have a solution out of the box.

Semper-Viventem commented 6 years ago

A good idea. But when implemented as a separate dependency.

Jeevuz commented 6 years ago

Separate dependency will add a headache IMO. Because we cannot set internal access modifier to the fields and methods of separate module. Also, I don't see the big benefit from this split. This feature will add a few methods max.