search

dmdhrumilmistry / GooglePhish

Google account phishing tool written in python using django
83 stars 16 forks source link

[ Improvement ] Default credential not specify in docker documentation #8

Closed yannis-mlgrn closed 1 year ago

yannis-mlgrn commented 1 year ago

We can specify the defaults admin credential in the docker documentation to avoid people to lost time to search it in the Dockerfile

dmdhrumilmistry commented 1 year ago

@yannis-mlgrn Thank you for pointing it out. I'm actually planning to avoid including hardcoded strings anywhere, I'll be adding a feature that will allow users to configure default admin credentials when they start the container.

yannis-mlgrn commented 1 year ago

@dmdhrumilmistry, you're welcome, indeed it will be a good feature!! It's a great project, if you want help in certain tasks, don't hesitate to create issues! It will be with pleasure that I can try to help you 🤙🏻

dmdhrumilmistry commented 1 year ago

@yannis-mlgrn if you wanna contribute then I can assign it to you, let me know regarding the same

yannis-mlgrn commented 1 year ago

@dmdhrumilmistry, I can add docker secrets or arguments for username, password and email. This will allow the user to specify his credentials before build the image, and i think is a good solution because this credentials will not present in hard in the Dockerfile.

dmdhrumilmistry commented 1 year ago

okay, I'm assigning this task to you in a new issue. You can make the necessary changes and pull a PR. I'll merge it after review.

Can you comment something in this issue thread? so I can assign you the task