dmecke / ChatBundle

MIT License
15 stars 13 forks source link

Version of ChatBundle for Symfony 2.2* #1

Closed kabudu closed 10 years ago

kabudu commented 11 years ago

Hi, is there a version of your chat bundle compatible with Symfony 2.2.*? If not, do you have plans of releasing a version anytime soon? Thanks.

dmecke commented 11 years ago

Hi, actually, I wasnt aware that this bundle is used by others already as it is very basic. What are the incompatibilities with Symfony 2.2.*? I would like to remove them. Apart from that I plan to update this bundle with a much more complete system (channels, bans, updates without page reload) which I currently use in my browsergame Onlinetennis.net. I am currently extracting the parts to make it standalone so I can publish it here.

kabudu commented 11 years ago

Hi, thanks for the quick response. I haven't had the chance to discover the incompatibilities because I cannot get past the composer installation stage as your bundle has a requirement of Symfony 2.1.* defined. If there is a way to get around that restriction I'd love to know, or if you could relax that requirement I can give it a try and see if there are any incompatibilities. Nonetheless, the improvements that you have in mind sound excellent and I personally can't wait till you've made them. Thanks.

dmecke commented 11 years ago

I've updated the composer.json so it will at least install with Symfony 2.2.*. I would love to hear your feedback if everything works as expected. I am going to tag this version as 0.1 then. Furthermore, when I integrated the more complex system, it would be great if you give it a try so we can eliminate integration bugs quickly. As I said it comes from a complete game and there might be some quirks to make it completely independant then.

kabudu commented 11 years ago

Excellent! Thanks for doing that, much appreciated. I'll give the bundle a try and let you know how I get on. Sure, I'm up for trialling the new updates whenever they're ready.

kabudu commented 11 years ago

Hi, I've made an attempt to include the bundle in my application and these are the issues that I faced:

Having tried out the bundle, I can see that it was originally built for a single chat thread which unfortunately is not suited to my application as I'm looking to have user-to-user chat functionality. As a future upgrade I think it would be useful to have that as a configurable option.

dmecke commented 11 years ago

I tagged the old version 0.1 so it can still be used with Symfony 2.1., the ongoing development will now support Symfony 2.2. only, it should be refered in composer.json as 0.2. The new version won't work with Symfony 2.1.* anymore as the render(controller(-Syntax isn't supported by it. I also changed the route names, they are now prefixed with cunningsoft_. There should be no need to define your own routes for this bundle, even if you don't use annotations. You can simply add something like

cunningsoft_chat_bundle:
    resource: "@ChatBundle/Controller"
    type: annotation

to your main routing file and it should work out of the box.

Though you are right that user-to-user chats are not supported. My later update will include an additional bundle which enables users to create chat-groups which map to own channels. So this would enable them to do one-on-one chats, but maybe thats not exactly what you were looking for.

kabudu commented 11 years ago

Hi. Thanks for the additional changes and the pointer on using the annotation based routing. In relation to using the bundle in my application now that I think about it, the chat groups mapped to defined channels would still work for one aspect of my application where users can create groups and that would allow all members of a group to communicate with each other. On the other hand, I would still need a solution that can handle user-to-user chat (much like how facebook chat works).

dmecke commented 11 years ago

As the channel-system is very dynamic, it should be easy to add support for that. I think we just need an action for inviting (creatie channel and put user into it) and thats mainly it then.

Does the 0.2 version work on your system now?

kabudu commented 11 years ago

Hi, I haven't had a chance to try the 0.2 version but as soon as I do I'll let you know how I get on. As you've said I'm sure it would be simple enough to implement user-to-user chat with the functionality that your bundle currently provides. I'd be willing to contribute some code towards that.

medy36 commented 11 years ago

hi @dmecke

i Would like to have some informations about your Bundle, i would like to know if the chat isn't slow when there is more then 5 or 10 person at the friends list. i m upgrading a project from sf 1.4 to Sf 2.x that use a separate chat module which is very slow when many user's are in.

Thank you in advance for your help,

dmecke commented 10 years ago

The system uses simple ajax requests, so it's just a matter of how many connections your server can handle. You can adjust the load by tweaking the update_interval in the config.