search

dmecke / ChatBundle

MIT License
15 stars 13 forks source link

Don't use username property when rendering the user's identity #3

Closed mgersten-caxy closed 11 years ago

mgersten-caxy commented 11 years ago

Don't use the username property, rather rely on the __toString() function to specify how the user name should be presented (FOSUserBundle defaults to username)

dmecke commented 11 years ago

I think this is indeed a good idea and gives more flexibility. Could you change the AuthorInterface as well? Because the getUsername() is no more needed now, but the __toString() is.

mgersten-caxy commented 11 years ago

Sure, will update the PR later today

dmecke commented 11 years ago

Thanks a lot for the contribution!