Make buttons same height whether or not they contain icons

dmfrancisco / activo

Activo is a theme for Web-app-theme, Formtastic and Attrtastic

http://dmfrancisco.github.com/activo/

158 stars 14 forks source link

Make buttons same height whether or not they contain icons #9

Closed kaapa closed 13 years ago

kaapa commented 13 years ago

Elements of button class that do not contain an icon render 1px shorter than those that have.

This commit fixes that by shortening the vertical space required by an icon by 1px. Tested with Safari and Firefox, unfortunately I don't have IE at my disposal at the moment.

I want to address this as RailsAdmin has buttons with and without icons next to each other and the inconsistent heights make it look unpolished. For reference see http://demo.railsadmin.org/admin/players/1133.

dmfrancisco commented 13 years ago

Thank you again!

gunn commented 13 years ago

Ooh, nice catch @kaapa.

kaapa commented 13 years ago

Reviewing this today I noticed my patch doesn't seem to function on Safari; I must have worked too late last night... I'll send a new patch soon!