search

dmfs / http-client-essentials-suite

A lightweight http-client suite.
Apache License 2.0
11 stars 5 forks source link

Clean up HttpStatus, implements #68 #122

Closed dmfs closed 5 years ago

dmfs commented 5 years ago

Remove the is* methods. They should be implemented as Predicates instead. Also rename SimpleHttpStatus to StructuredHttpStatus to align the name with other classes representing a "structured" value.

codecov[bot] commented 5 years ago

Codecov Report

Merging #122 into 1.0-dev will decrease coverage by 0.06%. The diff coverage is 12.9%.

Impacted file tree graph

@@              Coverage Diff              @@
##             1.0-dev     #122      +/-   ##
=============================================
- Coverage      65.92%   65.85%   -0.07%     
+ Complexity       525      501      -24     
=============================================
  Files            149      149              
  Lines           1617     1602      -15     
  Branches         109      109              
=============================================
- Hits            1066     1055      -11     
  Misses           497      497              
+ Partials          54       50       -4
Impacted Files Coverage Δ Complexity Δ
...fs/httpessentials/status/StatusLineHttpStatus.java 85.71% <ø> (-5.96%) 6 <0> (-10)
...org/dmfs/httpessentials/status/NoneHttpStatus.java 57.14% <ø> (-17.86%) 5 <0> (-5)
...org/dmfs/httpessentials/okhttp/OkHttpResponse.java 66.66% <0%> (ø) 3 <0> (ø) :arrow_down:
...s/httpurlconnection/HttpUrlConnectionResponse.java 50% <0%> (ø) 3 <0> (ø) :arrow_down:
...mfs/httpessentials/apache4/EssentialsResponse.java 60% <0%> (ø) 3 <0> (ø) :arrow_down:
.../main/java/org/dmfs/httpessentials/HttpStatus.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../httpessentials/executors/following/Following.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...sentials/responsehandlers/FailResponseHandler.java 95.45% <50%> (-4.55%) 9 <0> (+1)
...fs/httpessentials/status/StructuredHttpStatus.java 87.5% <87.5%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e50f335...679db65. Read the comment docs.