search

dmfs / http-client-essentials-suite

A lightweight http-client suite.
Apache License 2.0
11 stars 5 forks source link

Added autogenerated OSGi metadata #151

Closed Mailaender closed 1 year ago

Mailaender commented 1 year ago

as I currently get a lot of class not found exception with @eclipse-m2e.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (13fb446) 59.68% compared to head (226bd13) 59.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ========================================= Coverage 59.68% 59.68% Complexity 516 516 ========================================= Files 163 163 Lines 1709 1709 Branches 116 116 ========================================= Hits 1020 1020 Misses 627 627 Partials 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dmfs commented 1 year ago

I guess the plugin needs to be applied to every module. Right now only the root module has OSGi METAINF.

dmfs commented 1 year ago

I've published version 1.22.0 but it probably won't fix the issue yet.

Mailaender commented 1 year ago

Yes, my patch is incomplete, but I also don't understand why

https://github.com/dmfs/http-client-essentials-suite/blob/e394321fac5ed46d4e09d927ca39c16608ef3da5/apache4-executor/build.gradle#L14

this does not get applied.

dmfs commented 1 year ago

I think it gets applied (otherwise I probably couldn't publish it). I guess you need to apply the plugin to every module.

dmfs commented 1 year ago

I see what you mean. The manifest declaration doesn't seem to make any difference. I'll look into that as well.