less gas - Githubissues

dmfxyz / murky

Merkle Proof Generator and Validator in Solidity

MIT License

368 stars 35 forks source link

less gas #3

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi,

Less gas on calls, is better use external or internal/private instead of public (in cases where it can be used)
If a variable is not set/initialized, it is assumed to have the default value 0, false, initializing a variable with value 0 without any specific purpose is a waste of gas

dmfxyz commented 1 year ago

closed as this goes against the current design. See above comment

ghost commented 1 year ago

Yep, I see it, I'm using it as a lib, so the calls are made externally, the saving is not very significant but I think it's around ~300 of gas (difficult, I haven't quantified it exactly) ( * externally call )

genesis (my code) -> call getProof, getProof call -> log2ceilBitMagic

(* for information purpose )