Deprecated use of regex

dmgerman / ninka

a license identification tool for Source Code

http://ninka.turingmachine.org

GNU General Public License v2.0

105 stars 31 forks source link

Deprecated use of regex #46

Open stevenklassen8376 opened 3 years ago

stevenklassen8376 commented 3 years ago

Ninka is giving me the following warning message:

Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^\s[0-9]{ <-- HERE 1-2}+\s[-)]/ at /opt/kss/lib/perl5/site_perl/Ninka/SentenceExtractor.pm line 117.

stevenklassen8376 commented 3 years ago

Changing the line to

s/^\s*[0-9]\{1-2\}+\s*[\-\)]//;

should fix it.

ulm commented 3 years ago

PR #41 contains a different fix for the problem.

stevenklassen8376 commented 3 years ago

Excellent. I see it was committed in January of 2018. When are you planning to merge it into master?