Modularization

[darxriggs]

The idea is to convert the different Perl scripts into Perl modules.

With this change Ninka can be used as a Perl module from inside Perl. It could also be packaged and be released as a CPAN module. I added perldoc to every module.

Usage:

use Ninka;

my $input_file = 'some/path/file_of_interest';
my $verbose = 0;

my $license_result = Ninka::process_file($input_file, $verbose);

There is no need for the intermediate files with this implementation - so I removed them. If they are required (e.g. to help debugging when adding new licenses), they could be easily generated again.

[jeremiah]

Did this ever get merged?

[darxriggs]

The pull request is quite young (4 days). So I am still waiting for an answer.

[jeremiah]

I understand from a mutual friend that Prof. German's research has moved into other areas. This may mean he's not putting as much time into ninka. Have you heard any answer from him? If not, I wonder if we might move onward and create a new tool based on ninka but using a Modern Perl approach. If that's of interest, perhaps we should begin from scratch since ninka is used by others and it doesn't look like updating it is in anyone's interest.

[darxriggs]

No, I haven't heard back from Prof. German.

All the changes I did to Ninka have been for an easier integration into the fossology tool (http://www.fossology.org). This was just a very short term project for me. My colleagues will take over.

The goal is to see if the fossology community likes Ninka and maybe will maintain/enhance it.

[dmgerman]

Sorry, i should have looked at this patch some time ago. My first impression THANK YOU. You have tackled the issues that I had with it. But we need to sort one major issue before we merge it: license. Between the time that you started working on this and today, Ninka has changed license from AGPLv3+ to GPLv2+. Would you be ok to license your changes under the GPLv2+? I'll do some testing in the meantime.

again, sorry for being unresponsible.

One more thing, there is branch called test, it contains two different files ninka-excel.pl and ninka-sqlite.pl. They are wrappers of ninka to generate the output rather than cluttering the current directory.

--dmg

--dmg

[darxriggs]

Licensing my changes under GPLv2+ is ok.

[darxriggs]

Hi. Some more time has passed. So I just wanted to check if there is any chance this pull-request will be applied? I could also prepare a new one, based on the commits the happened in the meantime.