darreneid commented 1 year ago

User Auth

Functionality

[x] The main button with logo should link to /
[x] Has working demo login
[x] Smooth, bug free navigation
Before Login
[x] The /login page should not display a link to Log In. Same for /signup
[ ] Going to a random route /oweiniouewbrviuwebv should redirect or display a 404 page
[x] Errors should display for both /signup and /login.
[x] Errors should clear when moving between /signup and /login.
[x] Can sign up a user
[x] Can sign in as a user
[ ] Can log out a user
[x] Can't sign up with the same username/email
[x] Pressing enter after filling out the session form should use the form data, not the demo user
After Login
[ ] Should not be able to visit /login or /signup
[x] Should be able to refresh the page and still be logged in
Style
[x] The elements are positioned correctly on the page
[x] Remove Redux logger and all console.log()'s from production
Seeds
[x] Adequate and appropriate seeds

dmgudeman commented 1 year ago

I think I met all criteria

darreneid commented 1 year ago

Notes:

I think your logout functionality is broken
- after logging out I refresh the page and stay logged in
- logging out should redirect to root path, currently is /logout
password inputs should be type='password' so text is hidden

dmgudeman commented 1 year ago

I fixed the issues with the auth module. Hopefully ready to sign off.