dmigwi / sample

0 stars 0 forks source link

Cleanup codebase #526

Open dmigwi opened 1 year ago

dmigwi commented 1 year ago

This issue encapsulates;

  1. deleting every file that is not relevant any longer
  2. remove commented out block of codes
  3. creating issues to address TODO: statements that haven't been done
  4. localize every string not yet localized

(Issue originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

More clean up: File below not used any more

https://code.cryptopower.dev/group/cryptopower/-/blob/master/ui/page/governance/ticket_selector.go

By Migwi Ndung'u on 2023-02-07T17:53:13 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

handle this deprecate function; https://gitlab.com/devchoplife/cryptopower/-/blob/23fba09ee641d651cf9fa156ef1624915203c801/ui/page/components/components.go#L234

By Migwi Ndung'u on 2022-11-28T12:37:40 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

https://code.cryptopower.dev/group/cryptopower/-/blob/master/ui/page/governance/treasury_page.go#L231

this block need to fix

image

By Justin Do on 2022-11-25T15:42:33 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

strings.Title() -> cases.Title()

By Justin Do on 2022-11-25T15:43:09 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

This file is empty:

ui/page/components/acct_mixer.go

By Migwi Ndung'u on 2022-11-28T10:53:57 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

https://code.cryptopower.dev/group/cryptopower/-/merge_requests/1149 Disables the need of having the following files.

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

unassigned @dmigwi

By Migwi Ndung'u on 2023-02-03T18:07:07 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

mentioned in merge request !1187

By Migwi Ndung'u on 2023-01-26T10:31:06 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

mentioned in merge request !1189

By Migwi Ndung'u on 2023-01-27T21:33:07 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1270 as child task

By Kennedy Izuegbu on 2023-02-08T08:13:34 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

changed the description

By Kennedy Izuegbu on 2022-11-25T14:09:34 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

assigned to @dmigwi

By Migwi Ndung'u on 2023-01-24T22:03:21 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

mentioned in merge request !1184

By Migwi Ndung'u on 2023-01-25T13:40:40 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1247 as child task

By Kennedy Izuegbu on 2023-01-26T08:43:23 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1250 as child task

By Kennedy Izuegbu on 2023-01-26T08:43:42 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1248 as child task

By Kennedy Izuegbu on 2023-01-26T08:43:30 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1249 as child task

By Kennedy Izuegbu on 2023-01-26T08:43:37 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1251 as child task

By Kennedy Izuegbu on 2023-01-26T08:49:08 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

added #1261 as child task

By Kennedy Izuegbu on 2023-01-30T10:42:10 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)

dmigwi commented 1 year ago

mentioned in merge request !1186

By Migwi Ndung'u on 2023-01-26T10:13:42 (imported from GitLab)

(Comment originally authored by: @Kennedy Izuegbu in gitlab.com)